Repository navigation
NeXus hint: version-neutral (libNeXus before McCode#2895, HDF5 after) - #406
Merged
Merged
Conversation
Refs #405 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
g5t
reviewed
Oct 28, 2026
g5t
reviewed
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #405.
The
--verbosehint printed after embedding the runtime saidCompile with flags '-DUSE_NEXUS -lNeXus'. That's right for every McCode release so far. It stops being right once mccode-dev/McCode#2895 is released, because NeXus builds then link only HDF5. The classic code generator now says-lhdf5(ADR in McCode:docs/GRAMMAR/ADR-records/ADR_20261027_NEXUS_HDF5_COGEN_HINTS.md).mccode-antlr embeds the runtime of whichever McCode version it resolves, so neither literal is right for every user. This PR makes the hint version-neutral:
-DUSE_NEXUSplus the configuredflags.nexus. A comment notes which library each runtime needs.Changing the default
flags.nexusinplatforms.yamlaccording to the runtime version is the rest of #405. It waits for the McCode release number that includes #2895.Only a log message changes, so generated code is unchanged. No test checks the text; the file compiles. The test suite was not run.
🤖 Generated with Claude Code